Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor multipart until https:/defnull/multipart/issues/53 is addressed #400

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

glyph
Copy link
Member

@glyph glyph commented Sep 19, 2024

this is an attempt at a minimally-invasive integration, modifying it just enough to get our lint to pass without changing too much about either the lint configuration or the vendored file.

Fixes #399

@glyph glyph requested a review from a team September 19, 2024 18:59
@twm
Copy link
Contributor

twm commented Sep 19, 2024

Very quickly, this looks fine but is missing a news fragment. I'll have time to review properly this afternoon. Thank you for jumping on this @glyph!

@glyph
Copy link
Member Author

glyph commented Sep 19, 2024

missing a news fragment

Didn't even realize we are using towncrier here; we should get a check into CI!

Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you again @glyph! I will go ahead and roll a release.

@twm twm merged commit 9cedb08 into trunk Sep 19, 2024
19 checks passed
@twm twm deleted the vendor-multipart-for-now branch September 19, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants