Skip to content

Commit

Permalink
kversion: stabilize v3.3
Browse files Browse the repository at this point in the history
Using kcl probe version, this now properly detects 3.3
  • Loading branch information
twmb committed Oct 6, 2022
1 parent 3e02574 commit 750bf54
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion pkg/kversion/kversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ func (vs *Versions) VersionGuess(opts ...VersionGuessOpt) string {
{max300, "v3.0"},
{max310, "v3.1"},
{max320, "v3.2"},
{max330, "v3.3"},
} {
for k, v := range comparison.cmp.filter(cfg.listener) {
if !skip[int16(k)] && v != -1 {
Expand Down Expand Up @@ -349,6 +350,7 @@ func V2_8_0() *Versions { return zkBrokerOf(max280) }
func V3_0_0() *Versions { return zkBrokerOf(max300) }
func V3_1_0() *Versions { return zkBrokerOf(max310) }
func V3_2_0() *Versions { return zkBrokerOf(max320) }
func V3_3_0() *Versions { return zkBrokerOf(max330) }

func zkBrokerOf(lks listenerKeys) *Versions {
return &Versions{lks.filter(zkBroker)}
Expand Down Expand Up @@ -910,7 +912,7 @@ var max320 = nextMax(max310, func(v listenerKeys) listenerKeys {
return v
})

var maxTip = nextMax(max320, func(v listenerKeys) listenerKeys {
var max330 = nextMax(max320, func(v listenerKeys) listenerKeys {
// KAFKA-13823 55ff5d360381af370fe5b3a215831beac49571a4 KIP-778
v[57].inc() // 1 update features

Expand All @@ -932,3 +934,7 @@ var maxTip = nextMax(max320, func(v listenerKeys) listenerKeys {

return v
})

var maxTip = nextMax(max330, func(v listenerKeys) listenerKeys {
return v
})

0 comments on commit 750bf54

Please sign in to comment.