Skip to content

Commit

Permalink
remove misleading comment on DescribeGroups
Browse files Browse the repository at this point in the history
An empty group list does *not* describe all groups on a broker.

I've checked the Kafka source to ensure this (KafkaApis.scala) and
checked the Kafka source protocol definition.
  • Loading branch information
twmb committed Nov 19, 2020
1 parent 7c2ee82 commit 9d1238b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion generate/definitions/15_describe_groups
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// DescribeGroupsRequest requests metadata for group IDs.
DescribeGroupsRequest => key 15, max version 5, flexible v5+, group coordinator
// Groups is an array of group IDs to request metadata for.
// If this is empty, the response will include all groups.
Groups: [string]
// IncludeAuthorizedOperations, introduced in Kafka 2.3.0, specifies
// whether to include a bitfield of AclOperations this client can perform
Expand Down
1 change: 0 additions & 1 deletion pkg/kmsg/generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9d1238b

Please sign in to comment.