all: add support for KIP-784

https://cwiki.apache.org/confluence/display/KAFKA/KIP-784%3A+Add+top-level+error+code+field+to+DescribeLogDirsResponse
twmb · Feb 13, 2022 · a13f918 · a13f918
1 parent 1afca16
commit a13f918
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -325,6 +325,7 @@ generation.
 | [KIP-730](https://cwiki.apache.org/confluence/display/KAFKA/KIP-730%3A+Producer+ID+generation+in+KRaft+mode) - AllocateProducerIDs | 3.0 | Supported |
 | [KIP-734](https://cwiki.apache.org/confluence/display/KAFKA/KIP-734:+Improve+AdminClient.listOffsets+to+return+timestamp+and+offset+for+the+record+with+the+largest+timestamp) — Support MaxTimestamp in ListOffsets | 3.0 | Supported (simple version bump) |
 | [KIP-735](https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+session+timeout) — Bump default session timeout | ? | Supported |
+| [KIP-784](https://cwiki.apache.org/confluence/display/KAFKA/KIP-784%3A+Add+top-level+error+code+field+to+DescribeLogDirsResponse) — Add ErrorCode to DescribeLogDirs response| 3.1 | Supported |
 | [KIP-800](https://cwiki.apache.org/confluence/display/KAFKA/KIP-800%3A+Add+reason+to+JoinGroupRequest+and+LeaveGroupRequest) — Reason in Join/Leave group | 3.1 | Supported |
 
 Missing from above but included in librdkafka is:

diff --git a/generate/definitions/35_describe_log_dirs b/generate/definitions/35_describe_log_dirs
@@ -1,6 +1,6 @@
 // DescribeLogDirsRequest requests directory information for topic partitions.
 // This request was added in support of KIP-113.
-DescribeLogDirsRequest => key 35, max version 2, flexible v2+
+DescribeLogDirsRequest => key 35, max version 3, flexible v2+
  // Topics is an array of topics to describe the log dirs of. If this is
  // null, the response includes all topics and all of their partitions.
  Topics: nullable[=>]
@@ -12,6 +12,8 @@ DescribeLogDirsRequest => key 35, max version 2, flexible v2+
 // DescribeLogDirsResponse is returned from a DescribeLogDirsRequest.
 DescribeLogDirsResponse =>
  ThrottleMillis(1)
+ // The error code, or 0 if there was no error.
+ ErrorCode: int16 // v3+
  // Dirs pairs log directories with the topics and partitions that are
  // stored in those directores.
  Dirs: [=>]

diff --git a/pkg/kmsg/generated.go b/pkg/kmsg/generated.go
diff --git a/pkg/kversion/kversion.go b/pkg/kversion/kversion.go
@@ -889,5 +889,8 @@ var maxTip = nextMax(max300, func(v listenerKeys) listenerKeys {
  // KAFKA-13496 bf609694f83931990ce63e0123f811e6475820c5 KIP-800
  v[13].inc() // 5 sync group
 
+ // KAFKA-13527 31fca1611a6780e8a8aa3ac21618135201718e32 KIP-784
+ v[35].inc() // 3 describe log dirs
+
  return v
 })