Skip to content

Commit

Permalink
client: remove 30s default write timeout
Browse files Browse the repository at this point in the history
The reasoning for not having the default (potentially user overrided)
timeout was weak and could make some recovery situations slow, so let's
remove it. This now gives the sasl handshake 10s by default per step.
  • Loading branch information
twmb committed Oct 28, 2021
1 parent 10ff785 commit c197efd
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions pkg/kgo/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,6 @@ func (c *connTimeouter) timeouts(req kmsg.Request) (r, w time.Duration) {
case *kmsg.FetchRequest:
return def + millis(t.MaxWaitMillis), def

// SASL may interact with an external system; we give each step
// of the read process 30s by default.

case *kmsg.SASLHandshakeRequest,
*kmsg.SASLAuthenticateRequest:
return 30 * time.Second, def

// Join and sync can take a long time. Sync has no notion of
// timeouts, but since the flow of requests should be first
// join, then sync, we can stash the timeout from the join.
Expand Down

0 comments on commit c197efd

Please sign in to comment.