Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kadm stabilization: request for ideas #141

Closed
twmb opened this issue Mar 2, 2022 · 1 comment
Closed

kadm stabilization: request for ideas #141

twmb opened this issue Mar 2, 2022 · 1 comment

Comments

@twmb
Copy link
Owner

twmb commented Mar 2, 2022

The kdam package is a useful admin package. I'm not 100% sold on the API for offset type functions, nor on offset committing / fetching vs. batch committing / fetching.

I would also like to support the following APIs:

50_describe_user_scram_credentials
51_alter_user_scram_credentials
18_api_versions
10_find_coordinator
23_offset_for_leader_epoch

(difficult API?)
34_alter_replica_log_dirs
35_describe_log_dirs
45_alter_partition_assignments
46_list_partition_reassignments

(have not thought about APIs)
48_describe_client_quotas
49_alter_client_quotas
50_describe_user_scram_credentials
51_alter_user_scram_credentials
61_describe_producers
65_describe_transactions
66_list_transactions

(less important but still worth supporting)
38_create_delegation_token
39_renew_delegation_token
40_expire_delegation_token
41_describe_delegation_token

So, the above should be supported, and I would like feedback on the existing API before stabilizing. As well, I wonder what the story will be if Kafka adds something to the protocol that would necessitate an API change in kadm. Would this mean adding a new function, or bumping the major version?

If anybody wants to help implementation or chime in with API feedback, we can help drive this issue.
@twmb twmb mentioned this issue Mar 3, 2022
Closed
@twmb twmb pinned this issue Mar 7, 2022
@twmb twmb mentioned this issue Apr 11, 2022
Closed
10 tasks
twmb added a commit that referenced this issue May 1, 2022
@twmb
kadm: fix long standing poor API (Into fns)
b5256c7 
The Into functions for converting OffsetResponses, OffsetsList, and
ListedOffsets into Offset, as well as Offsets into kgo.Offset, were
non-obvious functions.

We add better names, for nowdeprecating the old. When we address the
rest of #141, we will remove the deprecated functions before stabilizing
the package.

The rest of the API seems pretty okay-ish for how large it is.
NewClient/NewOptClient is a little awkard, but any alternative names
aren't much better (ClientFromKgo/NewClient is my preference, but...
this is now widely used).
@twmb
Copy link
Owner Author

twmb commented Jun 1, 2022

I've stabilized 1.0 after adding support for describe and alter log dirs.

@twmb twmb closed this as completed Jun 1, 2022
@twmb twmb unpinned this issue Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twmb