sink: fix sequence number overflow during draining #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a follow-up to the 27880b4 which adds wrapping for sequence number while creating a new produce request. This patch adds checking for possible integer overflow for the batch0Seq, which could be assigned to the recBuf.seq during the resetBatchDrainIdx() which could cause INVALID_RECORD error. Signed-off-by: Ladislav Macoun <[email protected]>
|
🤦 good find, I aim to release this today. Technically I should have a v1.8.1, but I'd like to roll this into 1.9 so I don't have to back out of a few changes already merged (and don't have to have another branch lingering forever like v1.1.x which I may delete in one or two years..) |
|
This has been released in v1.9, thank you! |
|
Happy to help, and thank you for such a quick response 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow-up to the 27880b4 which adds wrapping for sequence number while creating a new produce request.
This patch adds checking for possible integer overflow for the batch0Seq, which could be assigned to the recBuf.seq during the resetBatchDrainIdx() which could cause INVALID_RECORD error.
Fixes #226
Signed-off-by: Ladislav Macoun [email protected]