Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish binary wheel with RocksDB included #30

Open
bauerj opened this issue Aug 9, 2018 · 8 comments · May be fixed by #67
Open

Publish binary wheel with RocksDB included #30

bauerj opened this issue Aug 9, 2018 · 8 comments · May be fixed by #67
Labels
enhancement

Comments

@bauerj
Copy link

bauerj commented Aug 9, 2018

Hey,

since it's not trivial to find and build a rocksdb version that works with this library, it would make sense to publish binary wheels on PyPi that include rocksdb.

Tools like https:/joerick/cibuildwheel make creating such wheels easy and automated.
@twmht
Copy link
Owner

twmht commented Sep 2, 2018

@bauerj

thanks for your great advise.

@bauerj
Copy link
Author

bauerj commented Sep 2, 2018

Let me know if I should send a PR!

@twmht
Copy link
Owner

twmht commented Sep 3, 2018

@bauerj

it's welcome to send a PR if you have interest.

@Omer-N
Copy link

Omer-N commented Jul 22, 2019

I agree it would be very useful, @bauerj did you solved that?

@twmht
Copy link
Owner

twmht commented Jul 22, 2019

pybind11 branch is already bundled with a specific version of rocksdb.

Try pip install after cloning the branch.

@bauerj bauerj linked a pull request Aug 19, 2019 that will close this issue
Open
@bauerj
Copy link
Author

bauerj commented Aug 20, 2019 •
edited
Loading

After a year of not working on this, I finally got around to implement this: #67

@nvictor
Copy link

nvictor commented Oct 2, 2019

@twmht i was wondering if you can take another look at the work @bauerj did here? i tried to deploy python-rocksdb to the Pivotal Cloud Foundry platform and only his binary wheel solution worked.

compiling using the pybind11 branch failed due to missing snappy package. there are many restrictions on the Pivotal Cloud Foundry platform due to security reasons. so one can't easily add new linux packages or libraries.

@twmht
Copy link
Owner

twmht commented Oct 2, 2019

sorry for very busy these months. I will look into the recent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Travis: Build binary wheels bauerj/python-rocksdb
4 participants
@nvictor @bauerj @twmht @Omer-N