Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6586 show error dialog on gist publishing error #6628

Merged
merged 3 commits into from
Jan 12, 2018
Merged

#6586 show error dialog on gist publishing error #6628

merged 3 commits into from
Jan 12, 2018

Conversation

MariuszJurowicz
Copy link
Contributor

No description provided.

@scottdraves
Copy link
Contributor

i disabled wifi and then published and got a blank error.
screen shot 2018-01-10 at 9 20 09 am

@MariuszJurowicz
Copy link
Contributor Author

MariuszJurowicz commented Jan 11, 2018 •
edited
Loading

xhr does not fail with the error the console logs (net:ERR_INTERNET_DISCONNECTED);
The only way i can show some message is to check the readyState when xhr fails. If the state is 0 there is some kind of network/connection problem so i can show eg. NETWORK_ERROR msg.

@MariuszJurowicz MariuszJurowicz mentioned this pull request Jan 11, 2018
Merged
@scottdraves scottdraves merged commit 17ac51b into master Jan 12, 2018
MariuszJurowicz pushed a commit that referenced this pull request Jan 30, 2018
#6586 show error dialog on gist publishing error (#6628)
7b9e66b 
* #6586 show error dialog on gist publishing error

* #6586 move gistPublish to extension dir

* #66586 show the network error in gist publishing dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariuszJurowicz @scottdraves