Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The charts didn't specify
metadata.namespace
anywhere so have added support for this. Have used the{{ .Release.Namespace }}
variable which defaults todefault
if not set. This makes it a non-intrusive change for anyone not wanting to use it, but a useful change for those who doFixed #41
Have tested against my own cluster with these commands:
Default namespace
helm upgrade \ --atomic \ --cleanup-on-fail \ --install \ --wait \ registry .
This deploys
registry
todefault
namespaceCustom namespace
helm upgrade \ --atomic \ --cleanup-on-fail \ --create-namespace \ --install \ --namespace registry \ --wait \ registry .
This deploys
registry
toregistry
namespace