Use scala versions define in .travis.yml #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.94% (diff: 100%)@@ master #1490 diff @@
==========================================
Files 244 244
Lines 3623 3623
Methods 3502 3502
Messages 0 0
Branches 121 121
==========================================
Hits 3331 3331
Misses 292 292
Partials 0 0
|
|
👍 |
Using sbt-travisci 'crossScalaVersions' and 'scalaVersion' are defined in terms of the scala versions defined in .travis.yml. Specifically, for 'scalaVersion' the last scala version is used (therefore either re-order them or override it in build.sbt if it's not the default you want). Also, define 'organization in ThisBuild' once instead of defining it in 'buildSettings' and appending it to every single project (in project scope). Finally, remove use of '%%' inside 'addSbtPlugin', it's overridden anyways by 'addSbtPlugin'.
Merged
|
The irony that this conflicts with #1499, which is a 2 commit PR, first updating build.sbt and then .travis.yml :-) (and then mentioning sbt-travisci) |
|
Hurrah! Thanks @dwijnand ! And thanks to @djspiewak for making me aware of this plugin |
|
Excellent. Thanks @adelbertc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using sbt-travisci
crossScalaVersionsandscalaVersionare defined in terms of the scala versions defined in .travis.yml. Specifically, forscalaVersionthe last scala version is used (therefore either re-order them or override it in build.sbt if it's not the default you want).Also, define
organization in ThisBuildonce instead of defining it inbuildSettingsand appending it to every single project (in project scope).Finally, remove use of
%%insideaddSbtPlugin, it's overridden anyways byaddSbtPlugin.