Override fromTry and fromEither for Try and Either #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an ApplicativeError law ensuring consistency between attempt/fromEither and pure.
Codecov Report
@@ Coverage Diff @@
## master #1660 +/- ##
==========================================
- Coverage 93.38% 93.33% -0.05%
==========================================
Files 240 240
Lines 3943 3945 +2
Branches 137 134 -3
==========================================
Hits 3682 3682
- Misses 261 263 +2
Continue to review full report at Codecov.
|
kailuowang
reviewed
May 11, 2017
| @@ -46,7 +46,8 @@ trait ApplicativeErrorTests[F[_], E] extends ApplicativeTests[F] { | |||
| "applicativeError handleErrorWith consistent with recoverWith" -> forAll(laws.handleErrorWithConsistentWithRecoverWith[A] _), | |||
| "applicativeError handleError consistent with recover" -> forAll(laws.handleErrorConsistentWithRecover[A] _), | |||
| "applicativeError recover consistent with recoverWith" -> forAll(laws.recoverConsistentWithRecoverWith[A] _), | |||
| "applicativeError attempt consistent with attemptT" -> forAll(laws.attemptConsistentWithAttemptT[A] _) | |||
| "applicativeError attempt consistent with attemptT" -> forAll(laws.attemptConsistentWithAttemptT[A] _), | |||
|
👍 thanks, I thought about raising those up in that PR, but somehow it slipped my mind. |
kailuowang
approved these changes
May 11, 2017
ceedubs
approved these changes
May 11, 2017
|
👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplicativeError#fromTryforTryApplicativeError#fromEitherforEitherApplicativeErrorensuring consistency betweenattempt+fromEitherandpure.The last two are sort of a follow up after #1651.