Add NonEmptyTraverse docs #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
force-pushed
the
add-non-empty-traverse-docs
branch
from
1fbbfb2
to
74f67c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1787 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 248 248
Lines 4454 4454
Branches 126 111 -15
=======================================
Hits 4257 4257
Misses 197 197Continue to review full report at Codecov.
|
|
LGTM, thanks! 👍 |
peterneyens
reviewed
Sep 12, 2017
|
|
||
| # NonEmptyTraverse` | ||
|
|
||
| `NonEmptyTraverse` is a non-empty version of the `Traverse` type class, just like `Reducible` is a non-empty version of `Foldable`. |
There was a problem hiding this comment.
Should we link to the Traverse documentation here?
ceedubs
suggested changes
Sep 20, 2017
|
|
||
| # NonEmptyTraverse` | ||
|
|
||
| `NonEmptyTraverse` is a non-empty version of the [Traverse](traverse.html) type class, just like [Reducible](reducible.html) is a non-empty version of [Foldable](foldable.html)`. |
There was a problem hiding this comment.
I think that there's a dangling backtick on this line.
ceedubs
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should eventually resolve #1747. Still WIP however, looking for some feedback :)