Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing factories similar to existing factories #2889

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Add missing factories similar to existing factories #2889

merged 1 commit into from
Jul 1, 2019

Conversation

morgen-peschke
Copy link
Contributor

Fixes #2887

kailuowang
kailuowang approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@morgen-peschke
Copy link
Contributor Author

@kailuowang, is there anything I can do to help get this merged?

@kailuowang kailuowang requested a review from LukaJCB June 26, 2019 22:29
@morgen-peschke
Copy link
Contributor Author

Thanks @kailuowang :)

@kailuowang kailuowang merged commit 6d29f7b into typelevel:master Jul 1, 2019
@morgen-peschke morgen-peschke deleted the feature/issue-2887/missing-typeclass-factories branch July 1, 2019 16:10
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Should factories like Semigroup.instance be provided for other typeclasses?
3 participants
@morgen-peschke @kailuowang @LukaJCB