SemigroupK sum: F[A], F[B] => F[A Either B] #3124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3124 +/- ##
==========================================
+ Coverage 93.17% 93.23% +0.06%
==========================================
Files 372 375 +3
Lines 7182 7292 +110
Branches 199 194 -5
==========================================
+ Hits 6692 6799 +107
- Misses 490 493 +3
Continue to review full report at Codecov.
|
| * {{{ | ||
| * scala> import cats.SemigroupK | ||
| * scala> import cats.data.NonEmptyList | ||
| * scala> SemigroupK[NonEmptyList].sum(NonEmptyList.one(1), NonEmptyList.one(2)) |
There was a problem hiding this comment.
This is nitpicky, but what do you think about using different types for this example? Otherwise looks good to me.
There was a problem hiding this comment.
I was hesitant about using NonEmptyList here, but I wasn't sure about the alternatives either, so I stayed with NEL.
do you perhaps have any suggestions which type could be used here instead? :)
There was a problem hiding this comment.
@pk044 Oh, sorry, that wasn't very clear. I think NonEmptyList is a good choice, just that using different values for A and B might make it a little clearer—e.g. something like:
SemigroupK[NonEmptyList].sum(NonEmptyList.one("abc"), NonEmptyList.one(2))There was a problem hiding this comment.
ok, i changed the value 👍
Closes #3112