Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and make private syntax methods that are now on Either #3149

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

travisbrown
Copy link
Contributor

All of these methods are available directly on Either now that we've dropped 2.11. We could probably just deprecate them to discourage explicit usage but I package-privated them as well since it might have some tiny effect on compile times.

@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 14, 2019
@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #3149 into master will decrease coverage by 0.06%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3149      +/-   ##
==========================================
- Coverage   93.28%   93.21%   -0.07%     
==========================================
  Files         376      376              
  Lines        7323     7323              
  Branches      195      195              
==========================================
- Hits         6831     6826       -5     
- Misses        492      497       +5
Flag Coverage Δ
#scala_version_212 93.55% <10%> (-0.08%) ⬇️
#scala_version_213 90.86% <10%> (-0.09%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/either.scala 83.08% <10%> (-3.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb9636...dda7f79. Read the comment docs.

@LukaJCB LukaJCB merged commit 038d683 into typelevel:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants