Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotty doesn't like local implicit vals without type annotations. I'm finally getting back to Dotty cross-building for tests after doing this for core and laws a few weeks back. In my view these changes are an improvement even on Scala 2.
The only non-trivial change is in
RepresentableSuite
, where there was some kind of weird code like this:The issue here is that
Representable.bimonad
has aRepresentable[Pair]
constraint, and theRepresentable[Pair]
instance has aFunctor[Pair]
constraint. ButbimonadInstance
is aFunctor[Pair]
. If you leave off the type annotation Scala is fine with this (because Scala), but if you put it on you get forward reference errors from the compiler. I've worked around this by invoking theRepresentable[X]
in an outer scope and assigning it to a non-implicit val.I've also removed the single bracket in
SemigroupKSuite
because some other weird stuff was happening that seems entirely unrelated to what's being tested there.