Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BinCompat extensions to syntax.apply import #3464

Conversation

gagandeepkalra
Copy link
Contributor

@gagandeepkalra gagandeepkalra commented Jun 10, 2020

This helps with specific import for apply

import cats.syntax.apply._ would now bring ifA to scope

@codecov-commenter
Copy link

Codecov Report

Merging #3464 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3464   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         382      382           
  Lines        8315     8315           
  Branches      210      210           
=======================================
  Hits         7617     7617           
  Misses        698      698           

@travisbrown travisbrown self-requested a review June 10, 2020 13:24
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely 👍 to ApplySyntaxBinCompat0, which I think must have been an oversight—thanks for catching it. What's the argument for ParallelApplySyntax, though? We don't do this for any of the other ParallelXSyntax traits.

@gagandeepkalra
Copy link
Contributor Author

I see parallel has a separate syntax grouping, thank you @travisbrown

@travisbrown travisbrown self-requested a review June 11, 2020 05:42
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@travisbrown travisbrown merged commit 93e6038 into typelevel:master Jun 11, 2020
@travisbrown travisbrown added this to the 2.2.0-M3 milestone Jun 12, 2020
@gagandeepkalra gagandeepkalra deleted the apply/syntax/addBinCompatTraitsToSpecificImports branch June 14, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants