Fix alleycats-tests on Scala.js #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
changed the title
joroKr21
force-pushed
the
alleycats-tests
branch
from
23a6b87
to
c58354b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3546 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 386 386
Lines 8564 8564
Branches 251 251
=======================================
Hits 7819 7819
Misses 745 745 |
* Add them to the PR build * Some minor build tweaks
joroKr21
force-pushed
the
alleycats-tests
branch
from
c58354b
to
d47ecdc
Compare
|
@barambani sorry for the new commit but it was easier this way to avoid conflicts. JS tests are much faster now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess accidentally broken by #3538 and went unnoticed because it was not part of the build.