Fix bug with Streaming#thunk. #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .thunk method is not supposed to memoize the results, allowing the caller to provide an impure function which returns different values on different calls. However, .thunk's definition used .knot with memoization, which completely defeated the point. This commit removes the memoization allowing this method to function correctly. Fixes #677.
| @@ -812,7 +812,7 @@ object Streaming extends StreamingInstances { | |||
| * traversals produce the same results. | |||
There was a problem hiding this comment.
I think this doc needs to be updated to no longer say that the result is memoized.
Current coverage is
|
|
👍 |
1 similar comment
|
👍 |
adelbertc
added a commit
that referenced
this pull request
Nov 20, 2015
Fix bug with Streaming#thunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .thunk method is not supposed to memoize the results,
allowing the caller to provide an impure function which
returns different values on different calls.
However, .thunk's definition used .knot with memoization,
which completely defeated the point. This commit removes
the memoization allowing this method to function correctly.
Fixes #677.