Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notes on conventions in test writing #734

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

mikejcurry
Copy link
Contributor

This PR looks to address #719 which was raised to add some guidance on test writing to the contributor guide related to conventions which have evolved over the course of cats development.

  • Note, that there seems to be a mix of “type class” and “typeclass” used throughout the codebase/docs so I chose “type class”; happy to change if a decision has been made on that.
  • This is far from perfect, but it’s a start and hopefully accurate.

@codecov-io
Copy link

Current coverage is 85.81%

Merging #734 into master will not affect coverage as of 4b57b9c

@@            master    #734   diff @@
======================================
  Files          162     162       
  Stmts         2249    2249       
  Branches        74      74       
  Methods          0       0       
======================================
  Hit           1930    1930       
  Partial          0       0       
  Missed         319     319       

Review entire Coverage Diff as of 4b57b9c

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Dec 9, 2015

Fantastic. Thanks! 👍

@stew
Copy link
Contributor

stew commented Dec 10, 2015

this is great, thanks @mikejcurry !

stew added a commit that referenced this pull request Dec 10, 2015
Add some notes on conventions in test writing
@stew stew merged commit 116a41c into typelevel:master Dec 10, 2015
@mikejcurry mikejcurry deleted the conventions-contributors branch December 11, 2015 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants