Delegate to Traverse.sequence in Applicative.sequence #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach duplicated the implementation of `sequence`, which is a slight code stink. More importantly though, this approach will benefit from an optimized override implementation of `sequence` if the `Traverse` instance has one.
Current coverage is
|
|
👍 |
1 similar comment
|
👍 |
adelbertc
added a commit
that referenced
this pull request
Feb 17, 2016
Delegate to Traverse.sequence in Applicative.sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach duplicated the implementation of
sequence, whichis a slight code stink. More importantly though, this approach will
benefit from an optimized override implementation of
sequenceif theTraverseinstance has one.