Add Future Order tests

[adelbertc]

No description provided.

[codecov-io]

Current coverage is 89.05%

Merging #895 into master will not affect coverage as of b60a213

@@            master    #895   diff @@
======================================
  Files          174     174       
  Stmts         2384    2384       
  Branches        76      76       
  Methods          0       0       
======================================
  Hit           2123    2123       
  Partial          0       0       
  Missed         261     261       

Review entire Coverage Diff as of b60a213

Powered by Codecov. Updated on successful CI builds.

[non]

👍

[ceedubs]

Thanks @adelbertc. I'm not so sure about this because of #589. Have you taken a look at that issue?

[adelbertc]

@ceedubs Just read through it again - the problem is the unlawfulness assumes side effects right? e.g. throwing exceptions, at which point we can't say anything about anything. In the absence of such things it appears to work

[ceedubs]

@adelbertc I don't think I quite see it that way. A failed Future is a perfectly valid case of a Future (similar to an Xor.Left), and it can be created without throwing exceptions. It's the Order[Future] instance that throws for a perfectly valid Future and therefore is the problematic piece (beyond blocking) in my opinion.

[adelbertc]

Ah fair.. in which case these test are bogus I think.