Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitraverse, fixes #800 #903

Merged
merged 2 commits into from
Feb 26, 2016
Merged

Add Bitraverse, fixes #800 #903

merged 2 commits into from
Feb 26, 2016

Conversation

adelbertc
Copy link
Contributor

Review by @travisbrown

@codecov-io
Copy link

Current coverage is 89.39%

Merging #903 into master will decrease coverage by -0.13% as of d9c49ac

@@            master    #903   diff @@
======================================
  Files          177     181     +4
  Stmts         2397    2423    +26
  Branches        76      76       
  Methods          0       0       
======================================
+ Hit           2146    2166    +20
  Partial          0       0       
- Missed         251     257     +6

Review entire Coverage Diff as of d9c49ac

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor Author

Realized last night I sorta need this for my talk next week, please review soon :D

@travisbrown
Copy link
Contributor

👍, looks great to me, but where's my bitraverseU? 😄

@adelbertc
Copy link
Contributor Author

@travisbrown I tried! I ran into a problem when I tried something like:

def bitraverseU[A, B, GC, GD](fab: F[A, B])(f: A => GC, g: B => GD)(implicit ULeft: Unapply[Applicative, GC], URight: Unapply[Applicative, GD]) = ???

and I needed to make sure ULeft.M was the same as URight.M. Maybe I'm encoding it wrong.. halp :-)

@travisbrown
Copy link
Contributor

@adelbertc That was kind of a joke—I've got a huge blog post on exactly that problem. My fix is in Scalaz, but I'm not sure it's worth it.

@adelbertc
Copy link
Contributor Author

@travisbrown ah :-) on one hand I'm glad to see I wasn't crazy, on the other hand I'm also kind of sad

@non
Copy link
Contributor

non commented Feb 26, 2016

Looks good to me. 👍

non added a commit that referenced this pull request Feb 26, 2016
@non non merged commit 724b1ad into typelevel:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants