Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spanR for IOLocal-based Trace #679

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

armanbilge
Copy link
Member

No description provided.

Comment on lines -82 to +86
local
.set(child)
.bracket(_ => fa.onError(child.attachError(_)))(_ => local.set(parent))
local.get.flatMap { old =>
local
.set(child)
.bracket(_ => fa.onError(child.attachError(_)))(_ => local.set(old))
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent span for this Resource is not necessarily the span that was installed on the IO at point of transformation.

@mpilquist
Copy link
Member

Thanks! A test for this would be welcome but shouldn't prevent merge. There's a bunch of infrastructure in InMemorySuite that I moved over from natchez-http4s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants