Support SpanKind and linked traces as Span options #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approach looks good to me! |
bpholt
force-pushed
the
span-options
branch
2 times, most recently
from
3d3f4b7
to
58a7207
Compare
the model implementation for these options comes from OpenTelemetry, so it's been added to core and the OpenTelemetry modules. Subsequent commits will implement this for other modules.
|
The |
mpilquist
reviewed
Jan 13, 2023
| def root(name: String): Resource[F, Span[F]] | ||
| final def root(name: String): Resource[F, Span[F]] = root(name, Span.Options.Defaults) | ||
|
|
||
| def root(name: String, options: Span.Options): Resource[F, Span[F]] |
There was a problem hiding this comment.
Would be good to add some docs about the use cases for options here. Nothing too extensive.
mpilquist
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry has the concepts of span kinds and linked traces, both of which I'd like to be able to specify for Natchez traces. This is a first draft of adding them to the Natchez API via the
Span.Optionsinterface, along with expanding where span options can be set.Right now only the core, OpenTelemetry, Jaeger, X-Ray, log, and no-op modules are updated to support the new attributes. I wanted to get feedback on the API before spending time figuring out how this maps into the other backends.