Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #676

Closed
1 task
iRevive opened this issue May 10, 2024 · 0 comments · Fixed by #679
Closed
1 task

Fix flaky tests #676

iRevive opened this issue May 10, 2024 · 0 comments · Fixed by #679
Assignees

Comments

@iRevive
Copy link
Contributor

iRevive commented May 10, 2024

There are a few:

  • SdkTracerSuite
Example

Job example: https:/iRevive/otel4s/actions/runs/9029200539/job/24811085216

==> X org.typelevel.otel4s.sdk.trace.SdkTracerSuite.startUnmanaged: use Clock[F].realTime to set start and end if builder's time is undefined  0.133s munit.ComparisonFailException: /home/runner/work/otel4s/otel4s/core/trace/src/test/scala/org/typelevel/otel4s/trace/BaseTracerSuite.scala:649
648:        // _ <- IO.println(tree.map(renderTree).mkString("\n"))
649:      } yield assertEquals(tree, List(expected(now)))
650:    }
values are not the same
=> Obtained
Nil
=> Diff (- obtained, + expected)
-Nil
+List(
+  Impl(
+    current = SpanInfo(
+      name = "span",
+      start = 1000000000 nanoseconds,
+      end = Some(
+        value = 1100000000 nanoseconds
+      )
+    ),
+    children = Nil
+  )
+)
@iRevive iRevive self-assigned this May 10, 2024
@iRevive iRevive linked a pull request May 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant