Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate semantic attributes using 1.23.1-alpha semantic convention #408

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Dec 19, 2023

it seems like scala steward did not notify us, and we're behind

Originally posted by @NthPortal in #336 (comment)


The semconv binary is published with the -alpha suffix, so we didn't receive updates.

@iRevive
Copy link
Contributor Author

iRevive commented Dec 19, 2023

I also run mima with an explicitly configured previous version locally. There are no binary issues.

Copy link
Contributor

@NthPortal NthPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment on lines +8 to +11
updates.allowPreReleases = [
# semconv is always published with `-alpha` suffix
{groupId = "io.opentelemetry.semconv", artifactId = "opentelemetry-semconv"}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously discussed this in #336 (comment). I don't think it will fix updates (or if so, then its a steward bug I think). But I suspect that something else is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be caused by non-trivial scope of the dependency?

libraryDependencies += 
  "io.opentelemetry.semconv" % "opentelemetry-semconv" % OpenTelemetrySemConvVersion % "compile-internal" intransitive (),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, maybe. Maybe the intransitive() is causing the dependency not to be exported to steward?

Copy link
Member

@bpholt bpholt Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a steward bug; I have to update the -alpha dependencies manually in some of our other projects (e.g. Dwolla/dwolla-otel-natchez@74d6a89) and I don't think there's anything special about them in that project.

@NthPortal
Copy link
Contributor

even if this doesn't fix the steward issue, it does fix the issue of our semconv package being out of date, so I say we merge and open an issue to try to track if steward works for the future

@iRevive iRevive merged commit 4c8e7c4 into typelevel:main Dec 20, 2023
10 checks passed
@iRevive iRevive deleted the update-sem-conv branch December 20, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants