Enhance core APIs to support Attributes
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the changed lines count makes this look scarier than it is; a lot of those lines are duplicated scaladocs |
iRevive
reviewed
Feb 13, 2024
core/metrics/src/main/scala-2/org/typelevel/otel4s/metrics/CounterMacro.scala
Show resolved
Hide resolved
iRevive
reviewed
Feb 13, 2024
core/metrics/src/main/scala-2/org/typelevel/otel4s/metrics/HistogramMacro.scala
Outdated
Show resolved
Hide resolved
iRevive
reviewed
Feb 13, 2024
core/trace/src/main/scala-2/org/typelevel/otel4s/trace/TracerMacro.scala
Outdated
Show resolved
Hide resolved
iRevive
reviewed
Feb 13, 2024
core/trace/src/main/scala-3/org/typelevel/otel4s/trace/TracerMacro.scala
Outdated
Show resolved
Hide resolved
iRevive
approved these changes
Feb 14, 2024
Add overloads of `Attribute[_]` varargs methods that accept `immutable.Iterable[Attribute[_]]`, to support use of `Attributes`.
NthPortal
force-pushed
the
attributes-api-support/PR
branch
from
df22897
to
005df37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overloads of
Attribute[_]varargs methods that acceptimmutable.Iterable[Attribute[_]], to support use ofAttributes.