Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformName to Attribute #503

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Add transformName to Attribute #503

merged 2 commits into from
Feb 21, 2024

Conversation

rossabaker
Copy link
Member

Use case: code that adds a prefix to all the names in a Seq[Attribute[_]]. Attribute.apply(prefix + old.name, old.`type`) won't work, because there is no access to KeySelect[A].

@iRevive
Copy link
Contributor

iRevive commented Feb 15, 2024

This one is binary compatible, I think?

The bin compact is broken in the upcoming release anyway 🙂

P.S. I guess we can have a release by the end of the current week.

@NthPortal
Copy link
Contributor

the alternative to this is to add an AttributeKey.apply method that takes a name and an AttributeType—because AttributeType is sealed, this doesn't allow users to create invalid keys

@iRevive iRevive merged commit 660411d into main Feb 21, 2024
21 checks passed
@iRevive iRevive deleted the transformName branch February 21, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants