sdk-metrics: add ExemplarFilter and TraceContextLookup
#596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iRevive
commented
Apr 13, 2024
iRevive
commented
| Reference | Link |
|---|---|
| Spec | https://opentelemetry.io/docs/specs/otel/metrics/sdk/#exemplarfilter |
| Java implementation | ExemplarFilter.java |
iRevive
added
metrics
iRevive
commented
Apr 13, 2024
|
|
||
| /** Provides a way to extract [[TraceContext]] from the [[Context]]. | ||
| */ | ||
| trait TraceContextLookup { |
There was a problem hiding this comment.
Here is an example of the 'real' implementation: https:/iRevive/otel4s/blob/e5c1d041f4a7b025ee264c2358996f9e3a6031b1/sdk/all/src/main/scala/org/typelevel/otel4s/sdk/OpenTelemetrySdk.scala#L381-L394
@NthPortal I still keep in mind your idea to move TraceContext to the core-common. Perhaps we can even share the Context.Key[TraceContext] that way. Once we get closer to the final implementation, I will revisit it.
iRevive
force-pushed
the
sdk-metrics/exemplar-filter
branch
from
21cdeaa
to
a433efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.