Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk-metrics: use ExemplarReservoirs when they are really needed #665

Merged
merged 1 commit into from
May 4, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented May 4, 2024

Closes #664.

@iRevive iRevive added metrics Improvement to metrics module sdk module Features and improvements to the sdk module labels May 4, 2024
@iRevive iRevive force-pushed the sdk-metrics/exemplar-reservoirs branch from 4dbf4f3 to 1710cb9 Compare May 4, 2024 08:29
@iRevive iRevive merged commit 8992172 into typelevel:main May 4, 2024
10 checks passed
@iRevive iRevive deleted the sdk-metrics/exemplar-reservoirs branch May 4, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Improvement to metrics module sdk module Features and improvements to the sdk module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics SDK: don't create exemplar reservoirs when exemplars are disabled
1 participant