Adds ability to generate arbitrary Dates and UUIDs
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that the build is passing, just the reporting back to this pull request doesn't seem to work...? https://travis-ci.org/github/typelift/SwiftCheck/builds/703270249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
I added definitions of
arbitraryfor theDateandUUIDfoundation types. I also included unit tests for both.Why merge this pull request?
I believe these two generators are useful to may people, and especially the UUID generator is not trivial as it required me to study RFC 4122 and implement the UUID v4 spec.
What's worth discussing about this pull request?
Datautility functions for hex encoding. Those are also highly generic but not easy to find currently. Not sure if that's a problem or not.What downsides are there to merging this pull request?
None that I can think of.