Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exclude.test is not a function #16

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Conversation

dev-sda1
Copy link
Contributor

@dev-sda1 dev-sda1 commented Aug 3, 2022

Change Summary

Fixed a bug that was occurring in #15 where attempting to run a RegEx test on a provided expression would fail as it was attempting to call a function from a variable. RegExp has now been properly defined to perform the intended tests.

Running tests on local machine passed just fine, CI pipeline seems to give unrelated error with gatsby itself
image

PR Checklist

dev-sda1 and others added 4 commits August 3, 2022 22:44
Updated utils.js to correctly define RegExp for testing regular expressions defined in a user's gatsby-conifg.js file for the plugin
@jasonbosco
Copy link
Member

jasonbosco commented Aug 4, 2022

Thank you for the PR @dev-sda1!

Adding this for context for future users who might stumble on this: Previously excludes only accepted a Regex in the configuration (either expressed as /regex/ or new RegExp("regex")). When a string was passed in, it would error out with this error. Your PR now allows strings to be passed as matchers.

@jasonbosco jasonbosco merged commit ed11ce2 into typesense:master Aug 4, 2022
@jasonbosco
Copy link
Member

Published this in v0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants