Call extendWithNode on DeconstructorPatternNode. (#6217)

typetools · Oct 3, 2023 · 6fb842d · 6fb842d
1 parent b22d4cc
commit 6fb842d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/CFGTranslationPhaseOne.java b/dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/CFGTranslationPhaseOne.java
@@ -631,9 +631,11 @@ public Node visitDeconstructionPattern21(Tree deconstructionPatternTree, Void p)
  for (Tree pattern : nestedPatternTrees) {
  nestedPatterns.add(scan(pattern, p));
  }
-
- return new DeconstructorPatternNode(
- TreeUtils.typeOf(deconstructionPatternTree), deconstructionPatternTree, nestedPatterns);
+ DeconstructorPatternNode dcpN =
+ new DeconstructorPatternNode(
+ TreeUtils.typeOf(deconstructionPatternTree), deconstructionPatternTree, nestedPatterns);
+ extendWithNode(dcpN);
+ return dcpN;
  }
 
  /* --------------------------------------------------------- */

diff --git a/framework/src/main/java/org/checkerframework/framework/flow/CFAbstractTransfer.java b/framework/src/main/java/org/checkerframework/framework/flow/CFAbstractTransfer.java
@@ -38,6 +38,7 @@
 import org.checkerframework.dataflow.cfg.node.CaseNode;
 import org.checkerframework.dataflow.cfg.node.ClassNameNode;
 import org.checkerframework.dataflow.cfg.node.ConditionalNotNode;
+import org.checkerframework.dataflow.cfg.node.DeconstructorPatternNode;
 import org.checkerframework.dataflow.cfg.node.EqualToNode;
 import org.checkerframework.dataflow.cfg.node.ExpressionStatementNode;
 import org.checkerframework.dataflow.cfg.node.FieldAccessNode;
@@ -968,6 +969,14 @@ public TransferResult<V, S> visitMethodInvocation(
  finishValue(resValue, thenStore, elseStore), thenStore, elseStore);
  }
 
+ @Override
+ public TransferResult<V, S> visitDeconstructorPattern(
+ DeconstructorPatternNode n, TransferInput<V, S> in) {
+ // TODO: Implement getting the type of a DeconstructorPatternTree.
+ V value = null;
+ return createTransferResult(value, in);
+ }
+
  @Override
  public TransferResult<V, S> visitInstanceOf(InstanceOfNode node, TransferInput<V, S> in) {
  TransferResult<V, S> result = super.visitInstanceOf(node, in);