Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-length is not set properly #362

Closed
suculent opened this issue May 3, 2017 · 8 comments
Closed

Content-length is not set properly #362

suculent opened this issue May 3, 2017 · 8 comments

Comments

@suculent
Copy link

suculent commented May 3, 2017

Works on iPhone, but fails on certain Androids accessing the Captive Portal. Solution to fix this was straitforward... adding explicit Content-Length header before all ->send requests.

suculent pushed a commit to suculent/WiFiManager that referenced this issue May 3, 2017
@suculent
Copy link
Author

suculent commented May 3, 2017

Following solution works for me:

suculent@ada93b7

@scop
Copy link
Contributor

scop commented May 26, 2017

I was bitten by this on Android 7.1.2, and the suggested change works for me too, please apply.

@scop
Copy link
Contributor

scop commented Jul 10, 2017

@suculent, could you submit a pull request to get this fix in? Thanks!

@suculent
Copy link
Author

I've already done this quite a while ago #363

tzapu added a commit that referenced this issue Jul 10, 2017
fix for #362 - Setting Content-length explicitly - https:…
@tzapu
Copy link
Owner

tzapu commented Jul 10, 2017

thanks guys, merged

you need to download the latest master though, until there will be a release

@tzapu tzapu closed this as completed Jul 10, 2017
@tablatronix
Copy link
Collaborator

The sdk seems to already send content-length headers, I wonder why android is so picky about the order maybe ?

@suculent
Copy link
Author

suculent commented Sep 15, 2017 via email

@tablatronix
Copy link
Collaborator

Maybe this changed in SDK at some point, shrug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants