Updating the format of rawstatistics local config #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `Configuration` class requires that the type of merged values to be the same. It is also desirable that the order in which entries in the `realms` property retain the order in which they are read / processed. To this end the `realms` value has been changed to an array in the base config file. This commit propagates that change to its local config file.
|
NOTE This PR will fail until ubccr/xdmod#818 has been merged. |
jpwhite4
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
Configurationclass requires that the type of merged values to be thesame. It is also desirable that the order in which entries in the
realmsproperty retain the order in which they are read / processed. To this end the
realmsvalue has been changed to an array in the base config file. This commitpropagates that change to its local config file.
Motivation and Context
So that it plays nice w/ the newly updated rawstatistics.json base file in xdmod
Tests performed
Manual Testing via xsede docker && xdmod-dev port.
Types of changes
Checklist: