Refactor job data set analysis fields #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you also update the customization instructions here: https:/ubccr/xdmod-supremm/blob/xdmod10.5/docs/customization.md to reflect the new mechanism. |
|
@jpwhite4 I've updated the customization instructions. |
jpwhite4
requested review from
aaronweeden
and removed request for
eiffel777,
jpwhite4,
ryanrath and
connersaeli
aaronweeden
force-pushed
the
jobdataset-analytics-fields
branch
3 times, most recently
from
9717cf4
to
84f47e8
Compare
3 tasks
aaronweeden
force-pushed
the
jobdataset-analytics-fields
branch
3 times, most recently
from
cf65c9e
to
6746792
Compare
Primary author was @jtpalmer Co-Authored-By: Jeffrey T. Palmer <[email protected]>
aaronweeden
force-pushed
the
jobdataset-analytics-fields
branch
from
6746792
to
107d52a
Compare
aaronweeden
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves analysis fields from the PHP query class to the JavaScript ETL schema.
Requires changes in ubccr/xdmod#1449
The
catastropheandcpu_user_imbalancedtypehave been set toignoresince they were effectively ignored by the previous implementation.The order of the analysis fields in the REST response is changed as a result of this change; ubccr/xdmod#1804 should be merged first to avoid the GUI showing the analytics in a different order in the Job Viewer.
There is also a PR for https:/ubccr/xdmod-xsede/pull/447.
Motivation and Context
These changes are part of the raw statistics refactoring task.
https://app.asana.com/0/0/1192929664503858/f
Tests performed
Tested manually.
Types of changes
Checklist: