update composer and php-codesniffer dep #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this lock file work with the documented version of composer that we recommend on the developer docuementation? The documentation talks about composer version 1.2.4 and gives the caveats with this version. If this change modifies the version of composer then the documentation should be updated at the same time. If the lock file will not work with composer 1.2.4 then we should state this in the documentation. |
jpwhite4
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update lock file with php-codesniffer dependency stuck to a specific version, bring all repositories in line with same version
Motivation and Context
Make sure all composer.lock files match composer 1.3.x version
Tests performed
ran composer install without errors.
Types of changes