Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order scatter plot data by usage instead of efficiency statistic. #323

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

hltaylor26
Copy link
Contributor

Description

The limit on the scatter plot stores is set to 3000. If there are more than 3000 data points, we want to prioritize showing users with the most usage on the system first. This change sets the order_by parameter to sort by the usage statistic descending.

I also disabled turboThreshold for the charts - https://api.highcharts.com/highcharts/plotOptions.series.turboThreshold. Having this enabled was causing the color coding of efficient vs inefficient points to not work as expected when the limit met the turboThreshold and there is no performance benefit for us having it enabled as the data being plotted does not fit into the following categories as taken from the Highcharts docs: "When a series contains a data array that is longer than this, only one dimensional arrays of numbers, or two dimensional arrays with x and y values are allowed."

Motivation and Context

Fixes issue: https://app.asana.com/0/1201929110850019/1202109495471984/f
This issue was found while testing for XSEDE10.0 release.

Tests performed

Changes were tested on my port on metrics-dev.
https://metrics-dev.ccr.buffalo.edu:9001/#main_tab_panel:efficiency

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hltaylor26 hltaylor26 added the bug label Apr 13, 2022
@hltaylor26 hltaylor26 added this to the 10.5.0 milestone Apr 13, 2022
@jpwhite4 jpwhite4 changed the base branch from xdmod10.5 to xdmod11.0 November 16, 2023 15:28
@jpwhite4 jpwhite4 modified the milestones: 10.5.0, 11.0.0 Nov 16, 2023
@jpwhite4 jpwhite4 merged commit 9ccb8e4 into ubccr:xdmod11.0 Nov 16, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants