Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raw data regression test. #369

Merged

Conversation

aaronweeden
Copy link
Contributor

Description

This PR fixes intermittent failures of the raw data regression test. The failures are due to the fact that for the fresh_install test mode, the mapping of id to name in the modw_supremm.exit_status table is non-deterministic. As a result, requesting the rest/warehouse/raw-data endpoint with the filters[exit_status] parameter set to specific input values does not always produce the same output rows across multiple CI runs. This PR changes the test to instead filter by application, which reliably produces the same output rows due to a deterministic mapping of IDs to application names in modw.application across multiple runs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronweeden aaronweeden added this to the 11.0.0 milestone Dec 21, 2023
@aaronweeden aaronweeden marked this pull request as ready for review December 21, 2023 21:03
@aaronweeden aaronweeden merged commit fcb4ee7 into ubccr:xdmod11.0 Dec 21, 2023
3 checks passed
@aaronweeden aaronweeden deleted the fix-raw-data-regression-test branch December 21, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants