Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a silently failing integration test that also blocked other tests from running. It also fixes the subsequent failing tests that were masked by this bug. This PR does not fix the high-level problem that the integration tests silently fail when a test class is not properly constructed, but I believe that should be addressed in a separate PR.
Description
EfficiencyControllerProviderTest
by matching the test class to the test's filenameMotivation and Context
This bug in the test was introduced in #373 with the upgrade from
phpunit
version ~4 to version 9.6.Arguments are passed to that test class's constructor, however
phpunit
's TestCase class does not accept any arguments and causes the test to fail. This is problematic because the test fails silently and does not execute the other tests. This is silently failing error from the test:In addition to this test failing, there were subsequent tests that were also failing but never got executed. This PR includes fixes for those tests as well.
https://app.asana.com/0/159049597309611/1208001546005416
Tests performed
Tested by running the integration test
runtests.sh
script in a container and verifying that all tests pass.Types of changes
Checklist: