Ensure assist panel shows when there are no job tabs. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assist panel did not show when the job tabs were removed due to a right-click delete search in the search history tree. This was because the tab.removeAll() function did not fire the close event. Changed the code to listen to the destroy event which is always fired. Steps to test: - Open one or more jobs in the job viewer - in the searhc history tree right click on a search node and select 'Delete Search' - Click 'yes' when prompted With the original code the main tab panel is blank. This change results in the assist panel being displayed again.
plessbd
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The assist panel did not show when the job tabs were removed due to a
right-click delete search in the search history tree. This was because
the tab.removeAll() function did not fire the close event. Changed the
code to listen to the destroy event which is always fired.
Motivation and Context
Bug fix
Tests performed
Steps to test:
'Delete Search'
With the original code the main tab panel is blank. This change results
in the assist panel being displayed again.
Types of changes