Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error and define abstract methods in subclasses #196

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Fix syntax error and define abstract methods in subclasses #196

merged 2 commits into from
Jul 26, 2017

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Jul 26, 2017

Fix syntax error and define abstract methods in subclasses

Description

When the abstract methods performPreExecuteTasks() and performPostExecuteTasks were moved up into aAction aRdbmsDestinationAction some classes that directly extended aAction were not properly updated. Also fix syntax error in pdoIngestor logging.

Motivation and Context

Bugfix

Tests performed

Ran tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added bug Bugfixes Category:ETL Extract Transform Load labels Jul 26, 2017
@smgallo smgallo added this to the v7.0.0 milestone Jul 26, 2017
chakrabortyr
chakrabortyr approved these changes Jul 26, 2017
View reviewed changes
Copy link
Contributor

@chakrabortyr chakrabortyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smgallo smgallo merged commit d7cdb84 into ubccr:xdmod7.0 Jul 26, 2017
@smgallo smgallo deleted the etl/bugfix branch July 26, 2017 15:36
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Aug 8, 2017
@smgallo @ryanrath
Fix syntax error and define abstract methods in subclasses (ubccr#196)
758b3de 
* Fix syntax error and define abstract methods in subclasses.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Aug 8, 2017
@smgallo @ryanrath
Fix syntax error and define abstract methods in subclasses (ubccr#196)
9111cf2 
* Fix syntax error and define abstract methods in subclasses.
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Sep 18, 2017
@smgallo @ryanrath
Fix syntax error and define abstract methods in subclasses (ubccr#196)
8806ef2 
* Fix syntax error and define abstract methods in subclasses.
chakrabortyr pushed a commit to chakrabortyr/xdmod that referenced this pull request Oct 17, 2017
@smgallo @chakrabortyr
Fix syntax error and define abstract methods in subclasses (ubccr#196)
2f222d1 
* Fix syntax error and define abstract methods in subclasses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@chakrabortyr chakrabortyr chakrabortyr approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:ETL Extract Transform Load
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smgallo @plessbd @chakrabortyr