7.0/fix about tab #232
Merged
7.0/fix about tab #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the About tab is the first tab clicked, and the browser is Chrome then the hash passed to this function was: null. This would cause the function to error out when attempting to regex match against it. In Firefox the value provided in the same situation was: 'null'. Which allowed the 'match' function to not error out. This small change just coerces the value of 'hash' to a string if it is not already.
smgallo
approved these changes
Sep 8, 2017
Merged
chakrabortyr
pushed a commit
to chakrabortyr/xdmod
that referenced
this pull request
Oct 17, 2017
* Fixing case of non-string hash - If the About tab is the first tab clicked, and the browser is Chrome then the hash passed to this function was: null. This would cause the function to error out when attempting to regex match against it. In Firefox the value provided in the same situation was: 'null'. Which allowed the 'match' function to not error out. This small change just coerces the value of 'hash' to a string if it is not already. * Travis Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered a small bug during 7.0 testing. If the 'About' tab is the first tab you visit after loading XDMoD, while using Chrome, the 'activate' listener would error out due to the Ext.History.getToken() function returning: null. On Firefox the function returns "null" and does not error out.
Motivation and Context
It's good to have consistent behavior across browser.
Tests performed
Manual Testing: (Chrome)
- Navigate to XDMoD ( ensure that there is no hash, so just https://<xdmod_address>/
- Click the 'About' Tab
Expected Outcome:
- That the first item in the left hand navigation pane is automatically selected.
Types of changes
Checklist: