Make logrotate.d file not override global settings #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logrotate.d confs are loaded via "dumb" include statement in the logrotate.conf which "Reads the file given as an argument as if it was included inline where the include directive appears." (from manpage). Previous version was applying the 'rotate', 'weekly', 'compress', 'missingok', and 'datetext' parameters outside of the mustache brackets for the individual log files. This would override any settings made in the main system 'logrotate.conf' file before the include statement, thus altering global logrotate behavior.
jtpalmer
added
bug
jtpalmer
approved these changes
Dec 14, 2018
jtpalmer
previously requested changes
Dec 14, 2018
|
Thank you for bringing this issue to our attention. I didn't realize those directives would override other files. |
chakrabortyr
dismissed
jtpalmer’s stale review
Issues addressed as per our convo.
chakrabortyr
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved common logrotate parameters inside of the brackets for the various logfiles.
Description
logrotate.d confs are loaded via "dumb" include statement in the logrotate.conf which "Reads the file given as an argument as if it was included inline where the include directive appears." (from logrotate manpage).
Previous version was applying the 'rotate', 'weekly', 'compress', 'missingok', and 'datetext' parameters outside of the mustache brackets for the individual log files. This would override any settings made in the main system 'logrotate.conf' file before the include statement, thus potentially altering global logrotate behavior for the system.
Motivation and Context
xdmod shouldn't alter global logrotate.conf parameters (thus potentially altering logrotate behavior for the entire system without knowledge of the system administrators).
Tests performed
Running this version on our sytsems -- had to change the file as it was altering our global logrotate configuration.
Types of changes
Checklist: