Support simplesaml's internal session naming #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
reviewed
Jan 17, 2019
chakrabortyr
approved these changes
Jan 17, 2019
jpwhite4
reviewed
Jan 17, 2019
| @@ -47,10 +47,8 @@ You will need to modify the `config.php` file and make sure you modify the `meta | |||
| ), | |||
| ... | |||
| ``` | |||
| two other keys that might need to be set if you are having errors | |||
| If you are having errors you might need to check the trusted domains setting | |||
There was a problem hiding this comment.
How does the admin know if they need to check the settings? Please enumerate the conditions when they might need to and might not need to check them.
There was a problem hiding this comment.
If you are having errors
We had at least one person that had to change the trusted domains setting, I never figured out exactly what their setup was that made them have to do this. But since I had run into it once, I put it in there.
plessbd
added
enhancement
smgallo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleSAMLphp uses its own session name to store its information.
This fix makes it so that this actually works and keeps XDMoD working.
Also I hate waiting 3 seconds, I changed it to that when initially doing this to make testing easier, this sets it back down so that we aren't just sitting to sit.