Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debugging messages when executing SQL #783

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Improve debugging messages when executing SQL #783

merged 2 commits into from
Jan 25, 2019

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Jan 24, 2019

Description

Counts in debug messages were off by 1 due to the last array element containing only a newline after calling explode() on a string, which caused confusion.

Motivation and Context

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added the bug Bugfixes label Jan 24, 2019
@smgallo smgallo added this to the 8.1.0 milestone Jan 24, 2019
@smgallo smgallo requested a review from plessbd January 24, 2019 21:09
@smgallo smgallo merged commit 3f4a028 into xdmod8.1 Jan 25, 2019
@smgallo smgallo deleted the improve-sql-logging branch January 25, 2019 15:37
@smgallo smgallo added the Category:ETL Extract Transform Load label Mar 27, 2019
@smgallo smgallo changed the title Improve debugging messages Improve debugging messages when executing SQL Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:ETL Extract Transform Load
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smgallo @plessbd