Add initial summary charts for the cloud realm #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgallo
reviewed
Feb 18, 2019
templates/roles.d/cloud.json
Outdated
| }, | ||
| "group_by": "project", | ||
| "has_std_err": true, | ||
| "id": 0.00000000000004, |
There was a problem hiding this comment.
Remind me what the heck this id field is for...
There was a problem hiding this comment.
For the fun of it!
Upon discussion with @jpwhite4 we think it has to do with this being copied from the usage page where these "ID's" are used to store data in relation to the treeview. These have been removed from this pull request and has had no ill effects.
plessbd
force-pushed
the
add-cloud-summary
branch
from
381b869
to
5d9de0d
Compare
smgallo
approved these changes
Feb 18, 2019
plessbd
added
the
enhancement
jtpalmer
pushed a commit
to jtpalmer/xdmod
that referenced
this pull request
Feb 19, 2019
This adds two default summary tab charts when the cloud realm is enabled.
smgallo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two default summary tab charts when the cloud realm is enabled.