Prevent null usernames being added when ingesting cloud data #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o staging.union-user-pi-resource table
…t-null-usernames-being-added
plessbd
reviewed
Mar 5, 2019
| @@ -19,6 +19,9 @@ | |||
| "alias": "r", | |||
| "on": "r.id = raw.resource_id" | |||
| } | |||
| ], | |||
| "where": [ | |||
| "raw.user_name IS NOT NULL" | |||
There was a problem hiding this comment.
i believe this should be 4 spaces and not 2...
same with the other file.
plessbd
approved these changes
Mar 5, 2019
smgallo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the usernames that are null for a cloud event from being ingested and causing an error when running the cloud ingestor pipelines
Tests performed
Manually tested in docker and passed existing tests
Types of changes
Checklist: